Review Request: Synchronize tp-integration-daemon with subscription/publication states and newly added contacts

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3468/#review5093
-----------------------------------------------------------

Ship it!


I've only done a pretty superficial review of this, but it looks fine, so feel free to commit.

- George


On 2010-04-14 14:14:04, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3468/
> -----------------------------------------------------------
> 
> (Updated 2010-04-14 14:14:04)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> This patch makes tp-integration-daemon pick up the changes done at a subscription/publication level to telepathy contacts. Bottom line: now adding/removing contacts from tp-contactlist no longer screws up your nepomuk database.
> 
> Please note that tp-contactlist won't pick up changes in realtime: you have to restart it to see the effect. This is because tp-contactlist does not watch nepomuk resources for changes (my next target, after this patch and the other one will make it in)
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.h 1108285 
>   /trunk/playground/network/telepathy-integration-daemon/telepathy.trig 1108285 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.cpp 1108285 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.h 1108285 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.cpp 1108285 
> 
> Diff: http://reviewboard.kde.org/r/3468/diff
> 
> 
> Testing
> -------
> 
> Works, as shown in tp-contactlist.
> 
> 
> Thanks,
> 
> Dario
> 
>