Review Request: Synchronize tp-integration-daemon with subscription/publication states and newly added contacts

[Dario Freddi]

> On 2010-04-05 14:41:10, George Goldberg wrote:
> > In general, this all looks fine to me (usual disclaimer - I haven't compiled or tested it yet). 
> > 
> > The one area that seems to be a bit problematic is that when the TelepathyContact constructor is run, and doNepomukSetup() method is called. I see that you call the slots to handle subscription state and blocked status after calling doNepomukSetup(). Could perhaps some of the redundant code in doNepomukSetup() (at least the bit creating the isBuddyOf relationship) be removed?
> 
> Dario Freddi wrote:
>     Good catch - it probably is. I'll check it out later.

I added it to my local copy, but git-svn is not really rb-friendly. Consider that as addressed, though.


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3468/#review4876
-----------------------------------------------------------


On 2010-04-05 17:05:02, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3468/
> -----------------------------------------------------------
> 
> (Updated 2010-04-05 17:05:02)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> This patch makes tp-integration-daemon pick up the changes done at a subscription/publication level to telepathy contacts. Bottom line: now adding/removing contacts from tp-contactlist no longer screws up your nepomuk database.
> 
> Please note that tp-contactlist won't pick up changes in realtime: you have to restart it to see the effect. This is because tp-contactlist does not watch nepomuk resources for changes (my next target, after this patch and the other one will make it in)
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-integration-daemon/telepathy.trig 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.h 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.cpp 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.h 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.cpp 1109698 
> 
> Diff: http://reviewboard.kde.org/r/3468/diff
> 
> 
> Testing
> -------
> 
> Works, as shown in tp-contactlist.
> 
> 
> Thanks,
> 
> Dario
> 
>