Review Request: Synchronize tp-integration-daemon with subscription/publication states and newly added contacts

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3468/#review4878
-----------------------------------------------------------


As to moving groupAdded/groupRemoved to the Account class, sure it would reduce the number of connects, but would it really make a tangible performance difference in return for the increased code complexity? We're not expecting contact lists to be more than a few hundred long...

- George


On 2010-03-31 20:16:58, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3468/
> -----------------------------------------------------------
> 
> (Updated 2010-03-31 20:16:58)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> This patch makes tp-integration-daemon pick up the changes done at a subscription/publication level to telepathy contacts. Bottom line: now adding/removing contacts from tp-contactlist no longer screws up your nepomuk database.
> 
> Please note that tp-contactlist won't pick up changes in realtime: you have to restart it to see the effect. This is because tp-contactlist does not watch nepomuk resources for changes (my next target, after this patch and the other one will make it in)
> 
> BEWARE: this patch is dependent on another patch (eww) to Tp-Qt4, which lies in fd.o bug 27379, and will hopefully make it in before this patch will get merged.
> 
> Blocking contacts will come in a further revision, since I need some ontology changes.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-integration-daemon/telepathy.trig 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.h 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccount.cpp 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.h 1109698 
>   /trunk/playground/network/telepathy-integration-daemon/telepathycontact.cpp 1109698 
> 
> Diff: http://reviewboard.kde.org/r/3468/diff
> 
> 
> Testing
> -------
> 
> Works, as shown in tp-contactlist.
> 
> 
> Thanks,
> 
> Dario
> 
>