Review Request: in telepathy protocol, replacing alias by id, when finding the remote contact

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1372/#review2238
-----------------------------------------------------------

Ship it!


This looks fine. Please commit it. Sorry for taking so long to review it.

- George


On 2009-08-20 19:16:28, roide wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1372/
> -----------------------------------------------------------
> 
> (Updated 2009-08-20 19:16:28)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> When chat was started by a remote contact,my kopete was crashing. On investigating I found out that, the no of contacts getting appended in others was none, so i changed the check where it checks for the remote contact, from alias() to id(). 
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/kopete/protocols/telepathy/telepathychannelmanager.cpp 1013793 
> 
> Diff: http://reviewboard.kde.org/r/1372/diff
> 
> 
> Testing
> -------
> 
> yes. Now it is no longer crashing.
> 
> 
> Thanks,
> 
> roide
> 
>