Review Request: Add default "debug area" to libkopetetelepathy

[Abner Silva]

> On 2009-10-26 17:45:09, George Goldberg wrote:
> > /trunk/playground/network/kopete/protocols/telepathy/KopeteTelepathy/CMakeLists.txt, line 14
> > <http://reviewboard.kde.org/r/1977/diff/1/?file=13380#file13380line14>
> >
> >     I'm sure this is fine, but I'm just wondering, is area 14400 specific to Kopete's Telepathy plugin?
> 
>  wrote:
>     Yes, it's. But we already have this definition at: /trunk/playground/network/kopete/protocols/telepathy/CMakeLists.txt
>     and when I open kdebugdialog I can see this debug area marked as Kopete's Telepathy Plugin.
>     Do we really need to declare it again in the subdir? I don't have this reviewing patch applied in my tree and I can see all telepathy plugin debug.
>     
>     @Zimmerle: Did you check in your kdebugdialog if the 14400 area was enabled?
> 
>  wrote:
>     You probably saw the debug from the telepathyprotocol.cpp not from the KopeteTelepathy/*. Since the KopeteTelepathy/CMakeList.txt declares another projet (libkopetetelepathy) it does not consider the definitions made on its parent CMakeList (i guess).

As discussed on IRC it looks more like I'm seeing all kopete debugs since I've marked it to print all debugs inside kopete area. It's probably how everybody is seeing it. The best solution for that problem is to remove (move it up) the lipkopetetelepathy and put all source code in the same project. Until there I think we can use your patch which looks really good.


- Abner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1977/#review2814
-----------------------------------------------------------


On 2009-10-26 17:24:11, Felipe Zimmerle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1977/
> -----------------------------------------------------------
> 
> (Updated 2009-10-26 17:24:11)
> 
> 
> Review request for telepathy, Abner Silva and George Goldberg.
> 
> 
> Summary
> -------
> 
> Add KDE_DEFAULT_DEBUG_AREA definition in the CMakeList.txt
> to allow libkopetetelepathy to output its debugs messages in the correct "area".
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/kopete/protocols/telepathy/KopeteTelepathy/CMakeLists.txt 1039153 
> 
> Diff: http://reviewboard.kde.org/r/1977/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felipe
> 
>