[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=422191

Pino Toscano <pino at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[ABI break] 20.04 and       |[ABI break]
                   |20.04.1 have renamed        |KAccountsDPlugin changes
                   |symbols and needs and ABI   |its API without bumping the
                   |bump                        |libkaccount SONAME
                 CC|                            |nicolas.fella at gmx.de,
                   |                            |pino at kde.org

--- Comment #1 from Pino Toscano <pino at kde.org> ---
Note that the actual ABI change is not what Nicholas mention, but rather this:

diff --git a/src/lib/kaccountsdplugin.h b/src/lib/kaccountsdplugin.h
index 1f1f82f..178a3d3 100644
--- a/src/lib/kaccountsdplugin.h
+++ b/src/lib/kaccountsdplugin.h
@@ -54,7 +54,7 @@ class KACCOUNTS_EXPORT KAccountsDPlugin : public QObject
     Q_OBJECT

 public:
-    KAccountsDPlugin(QObject *parent = nullptr);
+    KAccountsDPlugin(QObject *parent, const QVariantList& args);
     virtual ~KAccountsDPlugin();

 public Q_SLOTS:
@@ -90,6 +90,4 @@ public Q_SLOTS:
     virtual void onServiceDisabled(const Accounts::AccountId accountId, const
Accounts::Service &service) = 0;
 };

-Q_DECLARE_INTERFACE(KAccountsDPlugin, "org.kde.kaccounts.DPlugin")
-
 #endif // KACCOUNTSDPLUGIN_H

Ie done as part of https://phabricator.kde.org/D27633, commit:
https://invent.kde.org/network/kaccounts-integration/-/commit/27487ab9276ca3a9b6ef4e8145b2279b5e38cd25

-- 
You are receiving this mail because:
You are the assignee for the bug.