[kpeople] [Bug 423845] IM log viewer Contacts and history empty

[Dimitar Petrovski]

https://bugs.kde.org/show_bug.cgi?id=423845

Dimitar Petrovski <dimeptr at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleixpol at gmail.com
            Version|20.04                       |unspecified
          Component|log-viewer                  |general
            Product|telepathy                   |kpeople
   Target Milestone|Future                      |---

--- Comment #1 from Dimitar Petrovski <dimeptr at gmail.com> ---
The actual problem comes from KPeopleVCard plugin which does not emit the
initialFetchComplete signal. The plugin is added as a dependency for KDE
Connect on Arch, so with KDE Connect installed the ktp-log-viewer is empty.

the following patch fixes the problem:
diff --git a/src/kpeoplevcard.cpp b/src/kpeoplevcard.cpp
index bfaf71e..20531f6 100644
--- a/src/kpeoplevcard.cpp
+++ b/src/kpeoplevcard.cpp
@@ -153,6 +153,8 @@ KPeopleVCard::KPeopleVCard()

     processDirectory(QFileInfo(*vcardsLocation));

+    emitInitialFetchComplete(true);
+
     connect(m_fs, &KDirWatch::dirty, this, [this](const QString& path) {
         const QFileInfo fi(path);
         if (fi.isFile())

I will try to make a fork and commit the patch.

It is my opinion that some timeout mechanism should be added in KPeople so that
the other plugins still get displayed even if one plugin fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.