[kpeople] [Bug 345769] Unmerging a single contact from person crashes

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=345769

Martin Klapetek <mklapetek at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kpeo
                   |                            |ple/2e6f9f89a5a224e510271d2
                   |                            |4dc8c4870b59e22da
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Martin Klapetek <mklapetek at kde.org> ---
Git commit 2e6f9f89a5a224e510271d24dc8c4870b59e22da by Martin Klapetek.
Committed on 03/04/2015 at 16:20.
Pushed by mklapetek into branch 'master'.

Extend the unit tests and fix a bug they uncover

I've been investigating a bug in contact list when unmerging a single
contact from a Person would leave empty rows (and originally would
crash), turns out that removing Contact from Person does not emit the
rows removed signal and so the model then tries to access invalid
contact (and we get "out of bounds" assert).

REVIEW: 123238

CHANGELOG: Fix model not being properly updated after removing a contact from
Person

M  +1    -0    autotests/fakecontactsource.cpp
M  +88   -2    autotests/personsmodeltest.cpp
M  +1    -0    autotests/personsmodeltest.h
M  +4    -0    src/personsmodel.cpp

http://commits.kde.org/kpeople/2e6f9f89a5a224e510271d24dc8c4870b59e22da

-- 
You are receiving this mail because:
You are the assignee for the bug.