[telepathy] [Bug 339196] crash when opening the group chat dialog in KTp::JoinChatRoomDialog::loadFavoriteRooms()

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=339196

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-common-internals/86e6
                   |                            |df06e2ac2c7c29e0d866a10a19f
                   |                            |dafb18211
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |0.9.0

--- Comment #3 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 86e6df06e2ac2c7c29e0d866a10a19fdafb18211 by David Edmundson, on
behalf of Diane Trout.
Committed on 18/10/2014 at 16:26.
Pushed by davidedmundson into branch 'kde-telepathy-0.9'.

Handle the case where there is not a valid recentRoomsGroup.

I have some inactive accounts and for some rason the Q\_FOREACH was
being executed by the readEntry was returning an invalid recent list.

This handles that case and prevents a crash when accessing off the end
of the list.

REVIEW: 120588
FIXED-IN: 0.9.0

M  +11   -7    KTp/Widgets/join-chat-room-dialog.cpp

http://commits.kde.org/telepathy-common-internals/86e6df06e2ac2c7c29e0d866a10a19fdafb18211

-- 
You are receiving this mail because:
You are the assignee for the bug.