[telepathy] [Bug 318529] Add contact dialog should allow to set a message for the user

David Edmundson kde at davidedmundson.co.uk
Sun Mar 30 16:50:52 BST 2014


https://bugs.kde.org/show_bug.cgi?id=318529

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-common-internals/ada8
                   |                            |ab0b03d1fdb649f961df5fe6646
                   |                            |080aa2c14

--- Comment #2 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit ada8ab0b03d1fdb649f961df5fe6646080aa2c14 by David Edmundson, on
behalf of Daniel Cohen.
Committed on 30/03/2014 at 15:51.
Pushed by davidedmundson into branch 'master'.

Added presence request message in the add contact dialog

Added an optional text input line for the capability of sending a message with
presence requests.

I'm not entirely sure of the HIG for making it clear that it's an optional
field, so put the label below for now - putting 'message (optional)' on the
left-hand label looks unreasonably awkward to me.

REVIEW: 117138

M  +16   -1    KTp/Widgets/add-contact-dialog.cpp
M  +1    -0    KTp/Widgets/add-contact-dialog.h
M  +24   -7    KTp/Widgets/add-contact-dialog.ui

http://commits.kde.org/telepathy-common-internals/ada8ab0b03d1fdb649f961df5fe6646080aa2c14

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kde-telepathy-bugs mailing list