[telepathy] [Bug 331533] [JJ] send file file chooser dialog says 'open'

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=331533

--- Comment #13 from Martin Klapetek <mklapetek at kde.org> ---
> But since that would not leave any scope of modifying the
KFileDialog later

What do you mean? We don't need the dialog later, we need it only that one time
and it should be deleted afterwards.

> Also as you mentioned that we need to make the file
> dialog ourselves

Yes, using "new KFileDialog(..)" instead of using the static helper methods
giving you the file name directly :) We actually do not create the dialog right
now, it all happens behind the scenes for us.

> so I chose making a new class instead.

There's no use for a whole class reimplementing things when all you need to do
is change one line; you would just move that one line inside the class (all the
instantiating would be there just like with normal KFileDialog). So it adds
code (more maintainance) for very very little gain.

(also when replying to bugs, can you please either comment via the web
interface or remove all of the previous mail, it makes the bug report too
noisy).

-- 
You are receiving this mail because:
You are the assignee for the bug.