[telepathy] [Bug 325183] Group chat theme preview in settings dialog is not loaded

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=325183

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-text-ui/9a0d4e6910767
                   |                            |879be731d09438213de10da4985

--- Comment #13 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 9a0d4e6910767879be731d09438213de10da4985 by David Edmundson, on
behalf of Diane Trout.
Committed on 04/03/2014 at 20:05.
Pushed by davidedmundson into branch 'kde-telepathy-0.8'.

Provide a proxy javascript can call to say when its finished initialising its
part of the AdiumThemeView. Fixes 325183

What I discovered is that occasionally the AdiumThemeView will fire its
loadFinished event before the body has finished loading. (which also means that
some of the javascript functions don't get defined as they're created from the
onLoad property of body.

What this patch does is injects a small proxy QObject (AdiumThemeViewProxy)
into the javascript environment in AdiumThemeView::injectProxyIntoJavascript().
The proxy gives javascript access to a signal that it can call at the end of a
new "configureEnvironment" javascript function.

I added the new function instead of adding the signal to the end of the current
initStyles functions because that appears to be overridable by some of the
themes.

Also since this now lets you definitavely know that javascript is ready to
append your messages, I removed some extra sendDemoMessages calls.

I'm not sure what happens if a theme tries to override data/Template.html
though.

Also I stuck AdiumThemeViewProxy in with the AdiumThemeView because it seemed
small and tightly coupled with AdiumThemeView. However it seems like the
convention is every class gets its own .h/.cpp file. So that might need to be
fixed.

REVIEW: 116559

M  +1    -3    config/appearance-config-tab.cpp
M  +33   -4    lib/adium-theme-view.cpp
M  +13   -0    lib/adium-theme-view.h

http://commits.kde.org/telepathy-text-ui/9a0d4e6910767879be731d09438213de10da4985

-- 
You are receiving this mail because:
You are the assignee for the bug.