[telepathy] [Bug 329875] KTP doesn’t recognize well URL patterns

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=329875

Martin Klapetek <mklapetek at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |0.8.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-common-internals/a7df
                   |                            |31b729f85cb7381263789010b6b
                   |                            |c4aba9e88

--- Comment #6 from Martin Klapetek <mklapetek at kde.org> ---
Git commit a7df31b729f85cb7381263789010b6bc4aba9e88 by Martin Klapetek.
Committed on 27/02/2014 at 17:36.
Pushed by mklapetek into branch 'master'.

Merge escape and URL filters into one

This is needed to avoid the URL filter detecting wrong link boundaries
as the escape filter would change eg. "<http://kde.org/>" to
<http://kde.org/> and then the URL filter would detect
"http://kde.org/&gt" as the actual link.

Switching the order wouldn't help because the escape filter would escape
the newly inserted <a href...> links and the user would
get <a href.../a> and no clickable links.

Therefore we first detect the links, replace them with placeholders,
then escape everything, then replace placeholders with actual links.

Reviewed-by: David Edmundson
FIXED-IN: 0.8.0

M  +0    -1    KTp/CMakeLists.txt
M  +53   -1    KTp/message-escape-filter.cpp
M  +2    -1    KTp/message-processor.cpp
D  +0    -60   KTp/message-url-filter.cpp

http://commits.kde.org/telepathy-common-internals/a7df31b729f85cb7381263789010b6bc4aba9e88

-- 
You are receiving this mail because:
You are the assignee for the bug.