[telepathy] [Bug 327008] Contacts not always (almost never) sorted

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=327008

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |0.8.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-common-internals/1be2
                   |                            |526bfc18254fdd335645bfcf236
                   |                            |efcc83ae8

--- Comment #6 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 1be2526bfc18254fdd335645bfcf236efcc83ae8 by David Edmundson.
Committed on 17/02/2014 at 12:19.
Pushed by davidedmundson into branch 'master'.

Add a workaround for broken sorting

There is a bug in QSortFilterProxyModel in which if sort() is called
on a model where all items are filtered out it will not start sorting
as it cannot map the proxy column to the source column.

This gets updated whenever there's an insertRows but not from
a dataChanged.

With the kpeople cache we load all items, but
none make it through the filter as everyone is assumed to be
offline whilst we query telepathy over DBus. When we get data
from Tp we will only ever call dataChanged() not insertRows()
so we hit the Qt bug.

This bug is fixed in Qt 5.2.1, but not in 4.x

REVIEW:115828
FIXED-IN: 0.8.0

DIGEST: Please do not put this in the commit log. No-one should see
how horrible this is.

M  +42   -5    KTp/Models/contacts-filter-model.cpp
M  +2    -0    KTp/Models/contacts-filter-model.h

http://commits.kde.org/telepathy-common-internals/1be2526bfc18254fdd335645bfcf236efcc83ae8

-- 
You are receiving this mail because:
You are the assignee for the bug.