[telepathy] [Bug 338605] The QML code uses hardcoded icon paths

[Matt Scheirer]

https://bugs.kde.org/show_bug.cgi?id=338605

Matt Scheirer <matt.scheirer at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matt.scheirer at gmail.com

--- Comment #1 from Matt Scheirer <matt.scheirer at gmail.com> ---
You can use iconName with a bunch of QML elements to specify icons according to
the Freedesktop Naming Scheme (see here:
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html)
that will inherit the users icon theme settings, and you can supply a fallback.

Here is an example from one of my other apps I just ripped out to show:

  Action {
    iconName: playing ? "media-playback-pause" : "media-playback-start"
    iconSource: playing ? "icons/kfaenza_media-pause.png" :
"icons/kfaenza_media-play.png"
  }

If the iconName has a corresponding system icon, it uses that first. If it does
not exist, it falls back to my specified iconSource, in which case I just
bundled the kfaenza theme icons in case, but in my experience I've never found
a circumstance where this fails. I don't use it anymore - this was just from
some old code I had early on.

So instead of setting iconSource, set iconName.

-- 
You are receiving this mail because:
You are the assignee for the bug.