[telepathy] [Bug 325506] Expansion of groups in the Contact List is not always remembered

[Renato Atilio]

https://bugs.kde.org/show_bug.cgi?id=325506

--- Comment #10 from Renato Atilio <renatoat at gmail.com> ---
Created attachment 86272
  --> https://bugs.kde.org/attachment.cgi?id=86272&action=edit
A proposed solution for this bug

I've debugged this situation and the groups that didn't expand were always
passed from rowsInserted to onNewGroupModelItemsInserted with invalid indices,
so the method returns, not expanding these groups.

I was not able to understand why exactly this was happening, so I came with a
working solution: even if the index passed to this method is invalid, it's
possible to recover it from the model with the parameters from rowsInserted
("start", actually). Details on the submitted patch.

I've worked on the 0.8 branch, so this bug is reproducible on 0.8.1.

I didn't create a review request for the patch yet because this bug is marked
as fixed. Please take a look at the solution and let me know if any further
information or correction is needed. If it looks OK, I'll submit a review
request.

-- 
You are receiving this mail because:
You are the assignee for the bug.