[telepathy] [Bug 300600] Crash when filtering contacts

David Edmundson kde at davidedmundson.co.uk
Fri Mar 29 12:47:46 GMT 2013


https://bugs.kde.org/show_bug.cgi?id=300600

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|http://commits.kde.org/tele |http://commits.kde.org/tele
                   |pathy-common-internals/8c2c |pathy-common-internals/ad75
                   |7498ed9b064ab6d9da27d250ecd |d44da148f7c2cdd6412e44823a8
                   |e9ae55c97                   |981f017b2
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|http://commits.kde.org/tele |http://commits.kde.org/tele
                   |pathy-common-internals/8c2c |pathy-common-internals/97dc
                   |7498ed9b064ab6d9da27d250ecd |73527aecaad4c5ac6337cb0affc
                   |e9ae55c97                   |599c6d1ad

--- Comment #9 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit ad75d44da148f7c2cdd6412e44823a8981f017b2 by David Edmundson.
Committed on 29/03/2013 at 02:47.
Pushed by davidedmundson into branch 'kde-telepathy-0.6'.

Re-fix crash in debug versions of Qt in contacts model

REVIEW: 109788

M  +5    -5    KTp/Models/contacts-model.cpp

http://commits.kde.org/telepathy-common-internals/ad75d44da148f7c2cdd6412e44823a8981f017b2

--- Comment #10 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 97dc73527aecaad4c5ac6337cb0affc599c6d1ad by David Edmundson.
Committed on 26/03/2013 at 16:41.
Pushed by davidedmundson into branch 'kde-telepathy-0.6'.

Fix crashes when using debug versions of Qt

Rewrite the logic of sourceDataChanged which was fundamentally broken
This was potentially emitting onDataChanged on the invalid QModelIndex,
especially now we use a flat model in the filtered view

REVIEW: 109726

M  +30   -26   KTp/Models/contacts-filter-model.cpp
M  +2    -1    KTp/Models/contacts-filter-model.h
M  +5    -0    KTp/Models/contacts-model.cpp

http://commits.kde.org/telepathy-common-internals/97dc73527aecaad4c5ac6337cb0affc599c6d1ad

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kde-telepathy-bugs mailing list