[telepathy] [Bug 316004] ktp-text-ui setting "Open new conversations:" only applies after restarting

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=316004

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-text-ui/1b1ea8a533f72
                   |                            |b3ccfeec554a3657ecaa9a6836e

--- Comment #10 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 1b1ea8a533f72b3ccfeec554a3657ecaa9a6836e by David Edmundson, on
behalf of Stefan Eggers.
Committed on 04/03/2013 at 12:55.
Pushed by davidedmundson into branch 'master'.

Combining settings in a singleton class so that there is no confusion about the
current settings.

Up to now the settings for where new chats open were loaded by
ktp-text-ui on startup and not re-read anymore. Changing the settings
in the config dialog had no immediate effect; only after the next
start of ktp-text-ui it finally changed.

Now whenever the settings get asked for the singleton provides the
current value. Thus every change to the settings via the config dialog
will take effect immediately.

Also gives a way to easily add new settings in one place. Will be
useful for implementing the additional settings required by bug 282201
(make it configurable if "user is typing" gets show") which needs two
more bools.

DIGEST:

REVIEW: 109268

M  +4    -15   app/telepathy-chat-ui.cpp
M  +0    -7    app/telepathy-chat-ui.h
M  +8    -30   config/behavior-config.cpp
M  +2    -2    config/behavior-config.h
M  +3    -0    lib/CMakeLists.txt
A  +6    -0    lib/KTp/TextChatConfig
A  +143  -0    lib/text-chat-config.cpp     [License: GPL (v2+)]
C  +28   -26   lib/text-chat-config.h [from: config/behavior-config.h - 062%
similarity]     [License: GPL]

http://commits.kde.org/telepathy-text-ui/1b1ea8a533f72b3ccfeec554a3657ecaa9a6836e

-- 
You are receiving this mail because:
You are the assignee for the bug.