[telepathy] [Bug 313965] KWallet does not report errors

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=313965

Martin Klapetek <martin.klapetek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Martin Klapetek <martin.klapetek at gmail.com> ---
Actually I just checked the auth-handler code for kwallet and here's the
process (can any KTp dev check my braindump):

1/ We get to handle the sasl channel, try open kwallet
2/ KTp::Wallet::Interface kicks in
2.1/ We check if KWallet is already opened, open it if not
2.2/ Return KTp::PendingWallet, which waits for KWallet to be opened (or
finishes right away if already opened)
3/ KTp::PendingWallet is finished(), we start requesting sasl channel
properties for the auth details

^ Now this would never happened if KWallet itself wouldn't signal "I'm ready to
be used", right?

So your wallet returned "Im ready" and we go on:
4/ Received channel properties, checking if Telepathy asks us for password (it
does)
5/ If we're trying to auth for the first time, we ask KWallet if it has a
password for us
5.1/ If it has, we try authenticate with KWallet password
5.2/ If not, we prompt for password dialog

So...your wallet said "I have a password for this account, here you go" and if
the password reading itself fails, we do return empty password
(KTp/wallet-interface.cpp line 123). But again - we're asking the wallet twice,
if it actually has the password we're asking for and we abort properly if not
(show the password dialog). 

To sum it up - I think it was simply KWallet malformed and I can't see anything
more we could do to check the state of your wallet. Therefore I'm closing it as
invalid. Guys, please recheck this and reopen if I've made a mistake. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.