[telepathy] [Bug 313525] ktp-text-ui crashes, possibly on "bad" sent/received message

Maksim Melnikau maxposedon at gmail.com
Sun Jan 20 08:54:55 GMT 2013


https://bugs.kde.org/show_bug.cgi?id=313525

--- Comment #3 from Maksim Melnikau <maxposedon at gmail.com> ---
I think segfault on incorrect dbus message is always a bug, data should be
checked, warning putted, and message skipped. And as I see processMessageQueue
have check for such kind of situations:

void TextChannel::Private::processMessageQueue() {
   while (!incompleteMessages.isEmpty()) {
       if (e->isMessage) {
            if (e->message.senderHandle() != 0 && !e->message.sender()) {
                break;
            }
       emit parent->messageReceived(e->message);
   }

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kde-telepathy-bugs mailing list