[telepathy] [Bug 308130] Close quick chat plasmoid if "open chat button is pressed"

Aleix Pol aleixpol at kde.org
Thu Feb 21 00:43:11 GMT 2013


https://bugs.kde.org/show_bug.cgi?id=308130

Aleix Pol <aleixpol at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/tele
                   |                            |pathy-common-internals/05ab
                   |                            |6ed4aa85438dd5fb7342ffcf4ad
                   |                            |837d15182

--- Comment #5 from Aleix Pol <aleixpol at kde.org> ---
Git commit afc97a65f78c7f7167e55cec6dd94b9b4fa77b21 by Aleix Pol.
Committed on 21/02/2013 at 01:41.
Pushed by apol into branch 'master'.

Clean up the code now that we sorted out the conversation closing

Don't request to close the conversation, it will be removed from
the model anyway

Take advantage of the last

M  +2    -8    chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml

http://commits.kde.org/telepathy-contact-applet/afc97a65f78c7f7167e55cec6dd94b9b4fa77b21

--- Comment #6 from Aleix Pol <aleixpol at kde.org> ---
Git commit 05ab6ed4aa85438dd5fb7342ffcf4ad837d15182 by Aleix Pol.
Committed on 21/02/2013 at 01:39.
Pushed by apol into branch 'master'.

Properly close conversations before delegating them to ktp-text-ui

Helps to make a more coherent behavior upon the detaching feature.

Reviewed by David Edmundson (reviewboard is not working properly... :/)
Related: bug 302602

M  +1    -0    KTp/Declarative/conversation.cpp
M  +1    -0    KTp/Declarative/conversation.h
M  +20   -10   KTp/Declarative/conversations-model.cpp
M  +3    -0    KTp/Declarative/conversations-model.h

http://commits.kde.org/telepathy-common-internals/05ab6ed4aa85438dd5fb7342ffcf4ad837d15182

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kde-telepathy-bugs mailing list