[telepathy] [Bug 318565] Presence plasmoid does not react on GlobalPresence::currentPresenceChanged()

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=318565

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kde at davidedmundson.co.uk

--- Comment #2 from David Edmundson <kde at davidedmundson.co.uk> ---
I agree that these two are behaving differently, and that needs fixing.

I don't agree with your conclusion. We shouldn't be calling requestPresence
when the currentPresence changes..  that's really wrong. The code that is
calling requestPresence() looks to be doing so accidentally because the model
changes. Git log does not make it look deliberate, the message says it was
changed to update the UI when external factors changed the presence, it does
not say anything about it being to set the presence.

Lets agree on what _should_ happen before we try and decide how to fix it.

Pretend we have 2 accounts,
One jabber : supports all statuses
Local XMPP: doesn't support XA, will set currentPresence to away if
requestedPresence is XA.

requestPresence XA.

What I understand you think should happen:
 - contact list shows "Away"
 - jabber account is away
 - local XMPP is away
 - presence applet shows away

What I think should happen:
 - contact list shows XA
 - jabber account is XA
 - local XMPP is Away
 - presence applet shows XA
(because everything should show the requestedPresence all the time)

-- 
You are receiving this mail because:
You are the assignee for the bug.