[Bug 311865] KTP ContactsModel has repeated roleNames

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=311865

Martin Klapetek <martin.klapetek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.klapetek at gmail.com

--- Comment #1 from Martin Klapetek <martin.klapetek at gmail.com> ---
For reference, here's the full code piece

    roles[CurrentPresenceRole] = "presence";
    roles[CurrentPresenceTypeRole] = "presenceType";
    roles[CurrentPresenceStatusRole] = "presenceStatus";
    roles[CurrentPresenceStatusMessageRole] = "presenceStatusMessage";
    roles[RequestedPresenceRole] = "requestedPresence";
    roles[RequestedPresenceTypeRole] = "requestedPresenceType";
    roles[RequestedPresenceStatusRole] = "requestedPresenceStatus";
    roles[RequestedPresenceStatusMessageRole] =
"requestedPresenceStatusMessage";
    roles[ConnectionStatusRole] = "connectionStatus";
    roles[ConnectionStatusReasonRole] = "connectionStatusReason";
    roles[AliasRole] = "aliasName";
    roles[AvatarRole] = "avatar";
    roles[PresenceRole] = "presence";
    roles[PresenceIconRole] = "presenceIcon";
    roles[PresenceStatusRole] = "presenceStatus";
    roles[PresenceTypeRole] = "presenceType";
    roles[PresenceMessageRole] = "presenceMessage";

The presence on top is account presence, the presence towards bottom is contact
presence (the model mixes accounts with contacts). We don't need half of these
roles anyway and should return KTp::Presence where possible.

...also the license header is wrong, I'm sure I didn't write this model.

-- 
You are receiving this mail because:
You are the assignee for the bug.