[kde-solaris] FIONREAD undeclared in kdelib/kdecore/network

[Stefan Teleman]

Isn't it easier to just do:

#if defined USE_SOLARIS
#include <sys/filio.h>
#endif

:-)

It's not like it is realistically possible to write code 100% free of 
OS specific #ifdef's.

Why add another define ? It may come with unknown (unitended) side 
effects. There's *waaaaay* too many compile line defines already. :-)

--Stefan

-----

On Saturday 21 August 2004 15:48, Christopher Layne wrote:
> I see your point too,
>
> So you're referring to ioctl.h?
>
> I'm not saying it's a Solaris nor gcc bug. I'm saying it's a
> compilation problem. GCC cannot possibly define BSD_COMP for
> everything - just because it's compiling on Solaris.
>
> KDE is obviously written with BSD heavily targeted. But if one
> expects full portability, the dev side has to take that into
> account by
>
> #ifdef USE_SOLARIS
> #define BSD_COMP
> #endif
>
> Or something similar.
>
> -cl
>
> On Sat, Aug 21, 2004 at 02:29:27PM -0400, Stefan Teleman wrote:
> > On Saturday 21 August 2004 03:58, Christopher Layne wrote:
> > > How is that a GCC bug?
> >
> > Because it needs -DBSD_COMP added. Solaris is no longer a
> > derivative of BSD, and has not been so for a long while. You
> > don't need -DBSD_COMP when building with SunProCC, and including
> > sys/fileio.h. Neither is sys/fileio.h guarded by #ifdef BSD_COMP
> > in Sun's header files.
> >
> > I do see your point that not requiring pointless defines makes
> > things easier, in general.
> >
> > --Stefan
> >
> > -----
> > --
> > Stefan Teleman          'Nobody Expects the Spanish Inquisition'
> > steleman at nyc.rr.com                          -Monty Python
>
> ___________________________________________________
> This message is from the kde-solaris mailing list.
> Account management: 
> https://mail.kde.org/mailman/listinfo/kde-solaris. Archives:
> http://lists.kde.org/.
> More info: http://www.kde.org/faq.html.

-- 
Stefan Teleman          'Nobody Expects the Spanish Inquisition'
steleman at nyc.rr.com                          -Monty Python