[Kde-scm-interest] [PATCH] scripty draft 1

Chani chanika at gmail.com
Tue May 26 09:18:43 CEST 2009


here's a first draft of adding git support to scripty. I've tried to keep all 
the svn code the same; the only nonessential change here was doing a cd $mod 
once instead of multiple times (this should only change behaviour if a module 
is a directory but cannot be entered, which seems very unlikely).

there are some issues with the code as it stands:

-if git checkout fails (which I'm not sure would ever happen), it may abort, 
in order to avoid doing things with the wrong branch of that module. I don't 
like that. I'm thinking it'd be better to remove that module from $releases 
and then patch findfiles to take a list of modules instead of getting that 
itself.

-I'm not sure if I should rebase when I pull, just in case strange things have 
happened to the git repo. maybe only if the first pull fails?

-I don't know whether we're going to keep using SVN_SILENT in git commit 
messages :)

-any git push will fail until the git repo is one scripty has full access to. 
git.kde.org would be nice, although I'd also be fine with giving scripty a 
gitorious account for now.

-I only have a little experience with git, so I might have overlooked some 
details. code review would be appreciated :)

other than that, the rest of it should theoretically work. :) I've tested bits 
of the logic (like that line using cut -c3-) but haven't tried to actually run 
makemessages on my own machine.

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scriptygit.diff
Type: text/x-patch
Size: 11220 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-scm-interest/attachments/20090526/fd6e5a1c/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-scm-interest/attachments/20090526/fd6e5a1c/attachment.sig 


More information about the Kde-scm-interest mailing list