[Kde-scm-interest] Post-commit hooks script

Oswald Buddenhagen ossi at kde.org
Fri Dec 4 01:58:45 CET 2009


On Thu, Dec 03, 2009 at 04:13:55PM -0800, Chani Armitage wrote:
> ah, yes... what happenes to a CCMAIL hook when the commit it was in is
> copied to another branch? moved to another location?
> or does git's magical tree structure take care of duplicates?
> 
each commit is supposed to show up (and consequently be cc'd) exactly
once - per repository.

i must admit i'm not sure what to do about public personal and team
clones. each repo has its own hooks, so depending on the configs, things
may show up multiple times, indeed.

the simplest approach is defining that kde's hooks are only for the
canonical repos. if teams want to be able to facilitate post-commit
review before the commits hit the mainline repository, they'd have to
set up own hooks with own keywords (which would not trigger the central
repo's hook), and of course own commit mailing lists.

> well, I imagine we might still have a problem if, say, a plasmoid
> moves from playground to kdebase... the whole history of that plasmoid
> would appear all at once, right?
> 
yes. that's one of the reasons why "repo aggregates" for anything of
non-trivial size are Bad (TM).
one could artificially limit the number of commits from a single push
(e.g., by cutting the oldest ones on each branch), but that's ugly,
obviously.


More information about the Kde-scm-interest mailing list