Krazy license checker

[Adriaan de Groot]

[[ kde-quality is a place to discuss quality assurance measures ]]

Jaison,

I've been looking at your Krazy license checker. It does a good job, but 
there's a couple of little tweaks I'd like to make:

1) The BSD license isn't checked, but the disclaimer of warranty is. This 
makes many files (when you use --verbose --quiet) weirdly "licensed": BSD 
LGPL, for instance. I'd like to change it to check more closely for one of 
the two clauses of the BSD license, and to move the disclaimer of warranty to 
a (no-warranty) annotation at the end of the --verbose output.

2) We should warn about "LGPL" and "Library GPL" phrases in the Copyright 
headers. Those should be "Lesser General Public License" in both cases.

3) The current setup with multiple ifs seems a bit hard to maintain. I'd like 
to move to a hash mapping identifying strings to names of licenses, something 
like this:

	"LGPL" => "LGPL (should be spelled out)"


I have an implementation which does this, ready to go. I'm regression testing 
it on the output of your checker. Step (2) will allow us to fix up the 
headers in a structured way -- it's sort-of needed, even, in order to avoid 
legal vagueness about the license.


So my questions to you are: 

1) Are you OK with this kind of change (3 in particular -- I can send you the 
code)?

2) Have you got any other plans for the license / copyright / header checkers?


-- 
CodeYard - scholier en Open Source
http://www.codeyard.net/

-- 
Adriaan de Groot
  KDE Quality Team   http://www.englishbreakfastnetwork.org/
  SQO-OSS Researcher http://www.sqo-oss.eu/