Refactoring [was: Introduction]

[Stephan Kulow]

Am Donnerstag, 6. Juli 2006 10:43 schrieb Marek Janukowicz:
> On Monday 03 July 2006 12:04, Adriaan de Groot wrote:
> > > Browsing through this group archive I've also found this: [Bug 125176]
> > > service menu management to kcontrol]. Whom should I contact if I want
> > > to implement this module?
> >
> > If there is no such module, then it's all yours. You mgiht want to post
> > intentions and questions to kde-devel at kde.org
>
> Looking through code necessary to implement this, I've found eg.
> kdebase/libkonq/konq_popupmenu.cc, which has one method
> (KonqPopupMenu::setup) spanning across over 600 lines, with some not really
> descriptive/searchable variable names, like "s" and at least 8 levels of
> nesting. My questions:
> 1. Should I refactor that, and if so - how should I test? Just compile and
> make some "clicking tests" or implement unit tests?
whatever you're able to do with unit tests, do so. The rest test as good as 
possible.

> 2. Given the answer to 1. is "yes" - after I complete, where should I send
> the patch - here or to kde-devel? I'm sorry, I'm a bit overwhelmed by the
> number of KDE mailing lists...
This mailing list is merely about getting people to start, development 
questions should go to kde-devel (even though konqueror things go to
kfm-devel and core things [like kdebase] goes to kde-core-devel :)

> 3. What about porting the changes to KDE 4? Should I also provide that?
KDE 3.5 can have bugfixing, but for sure not refactoring. So provide this only 
for KDE4

Greetings, Stephan