[RFC][Fwd: {PATCH] KGhostView and KViewView - icons and toolbars]

[James Richard Tyrer]

Aaron J. Seigo wrote:
> On Wednesday 22 December 2004 08:56, James Richard Tyrer wrote:
> 
>> Is there some preferred way to try to work on improvements?
> 
> 
> get a CVS account and be judicious in its use.
> 
> 
>> Rather than submit a bug report, I offered the changes that I had 
>> made to my system as possible improvements.  I posted to kde-devel
>>  and CCed the two maintainers.
> 
> 
> that's not terribly unusual during the Holidays ... people are away 
> and traveling or busy prepping for being away and traveling.
> 
So, I will wait till next year :-) to see if I hear from the maintainers.
> 
>> Haven't heard anything. :-(  Should I now file a bug report for the
>>  bugs that are already fixed on my system?
> 
> 
> if you can't find another way, yes... it's usually more useful to 
> find others to work with ...
> 
> this is one of the reasons it's important to "socialize" with other 
> contributors in projects you wish to get involved with.

Yes, I have started corresponding with a few people.

> notes on the patch itself: i'm not particularly fond of adding more 
> stuff to the toolbars

Yes, there *is* too much stuff on some toolbars.

> unless there are compelling reasons to do so.

Similar applications (e.g. Adobe Acrobat Reader) have these specific option

> also, changing the ui.rc files like that will end up clobbering any 
> customizations people may have made locally,

Changing the global *.rc file shouldn't have any affect on the
"$HOME/.kde/share/apps/<app-name>/<app-name>.rc" copy.

> so that adds to the "only for compelling reasons" rational.

I do note that it probably isn't a good idea to add these one or two 
options unless the toolbars are separated (in which case there is lots 
of room) -- shouldn't be done to merge with Main ToolBar.

> otherwise, the added icons patches look fine (though i'd want to try
>  it out first, which i won't be able to do until later today.) i'll 
> see if i can get around to getting those changes in CVS today ...

Thanks for your help.

--
JRT