[RFC][Fwd: {PATCH] KGhostView and KViewView - icons and toolbars]

[James Richard Tyrer]

Is there some preferred way to try to work on improvements?  Rather than 
submit a bug report, I offered the changes that I had made to my system 
as possible improvements.  I posted to kde-devel and CCed the two 
maintainers.  Haven't heard anything. :-(  Should I now file a bug 
report for the bugs that are already fixed on my system?

-- 
JRT

-------- Original Message --------
Subject: {PATCH] KGhostView and KViewView - icons and toolbars
Date: Mon, 06 Dec 2004 20:26:27 -0700
From: James Richard Tyrer <tyrerj at acm.org>
Reply-To: kde-devel at kde.org
To: kde-devel at mail.kde.org
CC: kretz kde.org <kretz at kde.org>, luis luispedro <luis at luispedro.org>

Suggested improvements:

To make the changes (first on my system) that I wanted rather than just 
file a bug report:

I have made new icons:

       Show/Hide Page List
       Fit to Screen
       Fit to Page Width

which have been committed.

Attached is my patch to have KGhostView (App & Part) and KViewView Part 
use them, and to add them to the toolbar.  This also fixes some 
nconsistencys.

This makes them use a separate toolbar like KSVG does.  I prefer it that 
way.

Yes, I know that KViewer is still inconsistent.  Next project. :-)

This patch has been "frontported" to HEAD but the patch can still be 
applied to KDE-3.3.2 so a separate back port shouldn't be needed.

--
JRT







-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kdegraphics-toolbars0.patch
Url: http://mail.kde.org/pipermail/kde-quality/attachments/20041222/ead2a8e8/kdegraphics-toolbars0.cc
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: file:///tmp/nsmail-2.asc
Url: http://mail.kde.org/pipermail/kde-quality/attachments/20041222/ead2a8e8/nsmail-2.asc