[patch] kdelibs/kdeprint cleanups

Michael Goffioul goffioul at imec.be
Mon Sep 29 14:54:14 CEST 2003


Brad Hards wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Currently there are some warnings when building kdelibs/kdeprint. Some
> are simple to fix, although I have changed behaviour a bit (see apidox for
> KIO::NetAccess::download()). Nothing major here.

Looks to me, but why don't you use the job viewer window as parent
widget for the download dialog in the diff below?

Michael.

> 
> Is this OK to commit?
> Index: management/kmjobviewer.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/kdeprint/management/kmjobviewer.cpp,v
> retrieving revision 1.42
> diff -u -4 -p -r1.42 kmjobviewer.cpp
> - --- management/kmjobviewer.cpp  13 Aug 2003 19:47:41 -0000      1.42
> +++ management/kmjobviewer.cpp  29 Sep 2003 11:32:05 -0000
> @@ -722,9 +722,9 @@ void KMJobViewer::slotDropped( QDropEven
>         KURLDrag::decode( e, uris );
>         for ( KURL::List::ConstIterator it = uris.begin();
>               it != uris.end(); ++it)
>         {
> - -               if ( KIO::NetAccess::download( *it, target ) )
> +               if ( KIO::NetAccess::download( *it, target, NULL ) )
>                         files << target;
>         }
> 
>         if ( files.count() > 0 )

-- 
------------------------------------------------------------------
Michael Goffioul		IMEC-DESICS-MIRA
e-mail: goffioul at imec.be	(Mixed-Signal and RF Applications)
Tel:    +32/16/28-8510		Kapeldreef, 75
Fax:    +32/16/28-1515		3001 HEVERLEE, BELGIUM
------------------------------------------------------------------




More information about the kde-print mailing list