[Kde-print-devel] [kdelibs] [Bug 223161] Print interface doesn't allow to select even/odd page (book printing also ?)

[azakitpgr at yahoo.co.uk]

https://bugs.kde.org/show_bug.cgi?id=223161

--- Comment #5 from azakitpgr at yahoo.co.uk ---
Looking at the source code (kdelibs/kdeui/dialogs/kdeprintdialog.cpp)
There is no difference between 4.8.5 & 4.12.4 (or indeed 4.13.1) but looking at
the following code:

// Hopefully Qt 4.9 will have native support for all Cups options, Odd/Even,
and page ranges
#if QT_VERSION < KDE_MAKE_VERSION(4,9,0)
    if ( KCupsOptionsWidget::cupsAvailable() ) {
        KCupsOptionsPagesWidget *cupsOptionsPagesTab = new
KCupsOptionsPagesWidget( dialog );
        KCupsOptionsJobWidget *cupsOptionsJobTab = new KCupsOptionsJobWidget(
dialog );
        dialog->setOptionTabs( QList<QWidget*>() << cupsOptionsPagesTab <<
cupsOptionsJobTab << customTabs );
        KCupsOptionsSettingsWidget *cupsOptionsSettingsTab = new
KCupsOptionsSettingsWidget( dialog );
        if ( pageSelectPolicy == SystemSelectsPages ) {
            dialog->setOption( QAbstractPrintDialog::PrintPageRange, true );
            cupsOptionsSettingsTab->setSystemSelectsPages( true );
        }
    } else {
        dialog->setOptionTabs( customTabs );
    }
#else // Qt >= 4.9
    dialog->setOptionTabs( customTabs );
#endif  // Qt < 4.9

suggests that my underlying Qt was upgraded changing the branch of code used
and the devs hope for Qt 4.9 native support for the lost feature was misplaced
hope :-)

If I'm correct, I suggest the #if QT_VERSION < KDE_MAKE_VERSION(4,9,0) test is
made more realistic so we don't lose the feature while waiting for Qt to do it
natively.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.