[Kde-print-devel] [Bug 180051] [KDE4] Need a way to have default printer settings

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=180051


Kevin Kofler <kevin.kofler at chello.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin.kofler at chello.at




--- Comment #27 from Kevin Kofler <kevin kofler chello at>  2010-02-28 03:39:51 ---
That patch as is causes https://bugzilla.redhat.com/show_bug.cgi?id=566304

The offending lines:
+     // set default color
+     if( cups->currentPPD()->color_device )
+       options.color->setChecked(true);
+     else
+       options.grayscale->setChecked(true);
and later:
+     // set default color
+     if( cups.currentPPD()->color_device )
+   setColorMode(Color);
+     else
+   setColorMode(GrayScale);

They should be changed to:
    if ( cups->currentPPD() )
      {
        // set default color
        if( cups->currentPPD()->color_device )
          options.color->setChecked(true);
        else
          options.grayscale->setChecked(true);
      }
and:
    if ( cups.currentPPD() )
      {
        // set default color
        if( cups.currentPPD()->color_device )
          setColorMode(Color);
        else
          setColorMode(GrayScale);
      }
(I matched the coding style of the surrounding code.)

I'm going to try changing this in the Fedora package and will attach a fixed
patch if this works.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.