[Kde-print-devel] Small patch

[Cristian Tibirna]

On 13 May 2007 11:03, Albert Astals Cid wrote:

[cut patch explanation. see ml-archive for copy]

> Ok to commit tomorrow?

I should think so.

Nevertheless, as you observed, the problem seems rather to be that KPrinter 
lacks an "Invalid" page size identifier. I didn't look at the code to see 
what the impact of adding one would be (e.g. put it with a "special" value -- 
e.g. 1000 or -1 -- in the PageSize enum). And if doable, adding it as soon as 
commit rules allow.

Returning A4 must have been a safety net implemented by Michael Goffioul long 
ago, on the reasoning that the printer should at least support _some_ kind of 
paper, most probably A4 (at least in Europe). (N.B. ... and in this light -- 
and as an afterthought -- introducing an "Invalid" page size would be wrong! 
Hmmm...)

-- 
Cristian Tibirna
KDE developer .. tibirna at kde.org .. http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-print-devel/attachments/20070513/360b73d2/attachment.pgp