Broken commits in KDE PIM

Nicolas Fella nicolas.fella at gmx.de
Sun Oct 13 22:35:37 BST 2024


Hi,

I just had to revert four "it compiles fine without kf deprecated
method" commits because it was not, in fact, compiling fine (which could
be seen on CI).

I find it rather concerning that such changes are pushed without proper
testing, and it find it even more concerning that when the CI is broken
things don't get fixed.

Furthermore the actual change is conceptually wrong too:

-ecm_set_disabled_deprecation_versions(QT 6.7.2 KF 6.7.0)
+ecm_set_disabled_deprecation_versions(QT 6.7.2 KF 6.8.0)

Frameworks 6.8 is still in development, so if we added any new
deprecations there it would cause an immediate build failure, which is
obviously very bad. ecm_set_disabled_deprecation_versions must never be
set to a future version for this reason.

Please take the necessary care when doing such changes in the future.

Cheers

Nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20241013/93c07803/attachment.htm>


More information about the kde-pim mailing list