D29773: [KJots] Drop LocalResourceCreator
Igor Poboiko
noreply at phabricator.kde.org
Fri May 15 11:42:42 BST 2020
poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.
REVISION SUMMARY
As I understood, the "create-resource-on-first-start" routine was part of migration to Akonadi process
back in KDE4 times. Now there is `firstrun` routine in Akonadi and `defaultsetup` in `kdepim-runtime`,
which creates default resources including Akonotes.
I think it should be safe to drop it from KJots.
Well, at least I don't see similar routines in other KDEPIM applications.
Since we now use `StandardActionManager`, we now can also provide user with an action to create a new resource
directly from KJots (if for some reason user don't have default one set up)
TEST PLAN
`make`
REPOSITORY
R573 KJots
BRANCH
auto-create (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29773
AFFECTED FILES
CMakeLists.txt
cmake/modules/FindXsltproc.cmake
src/CMakeLists.txt
src/kjotswidget.cpp
src/localresourcecreator.cpp
src/localresourcecreator.h
src/noteshared/CMakeLists.txt
src/noteshared/localresourcecreator.cpp
src/noteshared/localresourcecreator.h
To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200515/f0535ed2/attachment.htm>
More information about the kde-pim
mailing list