D29602: Add field "Folder" to theme content items and to message tool tip

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Thanks for the changes. One more change/optimization, please.

INLINE COMMENTS

> storagemodel.cpp:259
> +    
> +    if (!d->mFolderHash.contains(item.storageCollectionId())) {
> +        QString folder;

This requires two lookups: first in the `contains()` and then in the `value()`. Use `find()` instead, which returns an iterator. When the iterator is invalid, assemble the string and insert it, otherwise get the value from the iterator.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D29602

To: gordin, #vdg, dvratil
Cc: dvratil, kde-pim, jamesth, fbampaloukas, dvasin, hrouis, rodsevich, ach, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200514/3d6390df/attachment.htm>