D29676: [KJots] Use KConfigDialog and KConfigXT, fix config desktop file

[Igor Poboiko]

poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  This patch does following:
  
  1. Removes `KJotsConfigDlg` (child of `KCMultiDialog`) and changes the code to just use `KConfigDialog`
  2. Changes names of widgets in `.ui`-file (prepend `kcfg_`) to let `KConfigXT` take care of everything.
  
  (this also fixes invalid signal connections to disable label/spinbox when option `AutoSave` is not checked)
  
  3. Changes the layout of `.ui`-file to `QFormLayout` instead of `QGridLayout` with bunch of spacers
  4. Fixes the inconsistency where `KJots` kontact plugin had name `Notes`, but its settings plugin used `CfgDlgHierarchy=Notebooks`
  
  (because of that, `KJotsConfigMisc` appeared as a top-level `Misc` page in Kontact KCM, making in unclear which app do these settings belong)

TEST PLAN
  1. Changes in settings are still saved to the config
  2. `Misc` page now appears under `Notes` in Kontact KCM
  3. Triggering the `AutoSave` checkbox now correctly enables/disables the `AutoSaveInterval`

REPOSITORY
  R573 KJots

BRANCH
  settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29676

AFFECTED FILES
  data/kjots_config_misc.desktop
  src/confpagemisc.ui
  src/kjotsconfigdlg.cpp
  src/kjotsconfigdlg.h
  src/kjotswidget.cpp

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200512/8e9205e1/attachment.htm>