D29538: [KJots] Add StandardNoteActionManager

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Nice job, just some suggestions for improvements...

INLINE COMMENTS

> standardnoteactionmanager.cpp:411
> +    QWidget *mParentWidget = nullptr;
> +    StandardActionManager *mGenericManager = nullptr;
> +    QItemSelectionModel *mCollectionSelectionModel = nullptr;

Use `std::unique_ptr` for automatic memory management (or just allocate it on heap), you already initialize it in the constructor anyway.

> standardnoteactionmanager.cpp:597
> +
> +#include "moc_standardnoteactionmanager.cpp"

Shouldn't be needed.

> standardnoteactionmanager.h:184
> +    class Private;
> +    Private *const d;
> +    //@endcond

Make it an `std::unique_ptr<Private> const d`, so you don't have to delete it manually.

REPOSITORY
  R573 KJots

BRANCH
  standard-action-manager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29538

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200508/c7668f3c/attachment-0001.htm>