D29543: Import UriHandler code from KdepimDBusInterfaces

Allen Winter noreply at phabricator.kde.org
Fri May 8 20:47:11 BST 2020


winterz added inline comments.

INLINE COMMENTS

> urihandler.cpp:2
> +/*
> +  This file is part of KOrganizer.
> +

remove

> urihandler.cpp:37
> +
> +namespace {
> +

using CalendarSupport namespace?

> urihandler.h:2
> +/*
> +  This file is part of libkdepim.
> +

remove

> urihandler.h:29
> +
> +#include <AkonadiCore/Item>
> +

I don't see this being used at all.

> urihandler.h:34
> +/** URI handler. */
> +class CALENDARSUPPORT_EXPORT UriHandler
> +{

put into the CalendarSupport namespace

REPOSITORY
  R75 PIM: Calendar Support

REVISION DETAIL
  https://phabricator.kde.org/D29543

To: dvratil, #kde_pim
Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200508/7e0a108e/attachment-0001.htm>


More information about the kde-pim mailing list