D29287: [KJots] New signal / slot API & minor cleanup

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Looks good, just one nit pick - you can fix it before committing, I don't need to review it again.

INLINE COMMENTS

> localresourcecreator.cpp:49
>      const Akonadi::AgentInstance::List instances = Akonadi::AgentManager::self()->instances();
> -    bool found = false;
> -    for (const Akonadi::AgentInstance &instance : instances) {
> -        if (instance.type().identifier() == akonadiNotesInstanceName()) {
> -            found = true;
> -            break;
> -        }
> -    }
> +    bool found = std::any_of(instances.cbegin(), instances.cend(), [](const Akonadi::AgentInstance &instance) {
> +                                    return instance.type().identifier() == akonadiNotesInstanceName();

I'd make this `const bool`

REPOSITORY
  R573 KJots

BRANCH
  cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29287

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200502/54130d2e/attachment-0001.html>