D28448: Implement of "Protected Headers for Cryptographic E-mail". T742

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> encryptjobtest.cpp:225
> +    KMime::Content *encPart = MessageComposer::Util::findTypeInMessage(result, "application", "octet-stream");
> +    auto tempNode = new KMime::Content();
> +    {

Mem leak as it never deleted no ?

> encryptjob.cpp:127
>  
> +void EncryptJob::setSkeletonMessage (KMime::Message* skeletonMessage)
> +{

add missing space before (

> encryptjob.h:57
>      void setRecipients(const QStringList &rec) override;
> +    void setSkeletonMessage(KMime::Message* skeletonMessage);
> +

Message *skeletonMessage

> protectedheaders.cpp:69
> +
> +void ProtectedHeadersJob::setSkeletonMessage (KMime::Message* skeletonMessage)
> +{

add missing space before (

> protectedheaders.cpp:133
> +    auto subject = d->skeletonMessage->header<KMime::Headers::Subject>();
> +    for(auto header: d->skeletonMessage->headers()) {
> +        QByteArray headerType(header->type());

const auto &header ?

> protectedheaders.cpp:134
> +    for(auto header: d->skeletonMessage->headers()) {
> +        QByteArray headerType(header->type());
> +        if (headerType.startsWith("X-KMail-")) {

const

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D28448

To: knauss, #kde_pim, mlaurent
Cc: mlaurent, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200331/b08696ad/attachment.html>