D28436: [IncidenceTreeModel] Update UID if it was changed

Igor Poboiko noreply at phabricator.kde.org
Mon Mar 30 14:51:04 BST 2020


poboiko created this revision.
poboiko added a reviewer: dvratil.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  If one creates a Todo inside KOrganizer, it sets some default generated UID.
  Such UID can be changed by the resource afterwards. The model should handle this case.
  
  This patch adds a simple check: if the uid has changed inside `onDataChange, then just update the hashes.

TEST PLAN
  1. Add a Todo to Google Tasklist
  2. Add a subtodo instantly (without reloading the view)
  3. (without patch) Subtodo is added at the top level (parent was not recognized)
  4. (with patch) Subtodo is added below the parent todo

REPOSITORY
  R76 PIM: Event Views

BRANCH
  fix-id-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28436

AFFECTED FILES
  src/todo/incidencetreemodel.cpp

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200330/bad1593e/attachment.html>


More information about the kde-pim mailing list