D28431: Attachment open dialogue: Make the button order more useful

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
marten requested review of this revision.

REVISION SUMMARY
  This is the confirmation question that is shown when an attachment is opened.  Currently the button order is "Open With", "Open with <default application>", "Save as", "Cancel" where the "Open with <default application>" is only shown if there is a default application available for the MIME type.
  
  If the attachment does have an default application then the most likely action for the user would be to open it in that application.  Therefore it would be more useful to have the button to do this as the leftmost one - being first in the viewing order and more easily clickable.  So the button order would become "Open with <default application>", "Open With", "Save as", "Cancel".  The "Save as" button would still be the default, for security.

TEST PLAN
  Built messagelib with this change, open an attachment in KMail and observe that the button order is as proposed above.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D28431

AFFECTED FILES
  messageviewer/src/widgets/attachmentdialog.cpp

To: marten, #kde_pim
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200330/4530d71c/attachment.html>