D28178: [contacts] Fix ContactCreateJob with a photo

Daniel Vrátil noreply at phabricator.kde.org
Sat Mar 21 14:18:14 GMT 2020


dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Please fix the small nitpick before committing. Otherwise good to go. Thanks!

INLINE COMMENTS

> contactcreatejob.cpp:153
>          }
> +        bool hasPhoto = !d->contacts.current()->photo().isEmpty();
> +        if (hasPhoto) {

`const bool` (or just drop the variable altogether, your call)

REPOSITORY
  R477 KGAPI Library

BRANCH
  create-contact-photo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28178

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200321/cdfe1ba3/attachment-0001.html>


More information about the kde-pim mailing list