D28179: [contacts] Populate remoteId of newly created contact

[Igor Poboiko]

poboiko added a comment.


  Hmm, that's weird.
  I've looked into `CalendarResource` (say, `slotCreateJobFinished`) and the code there explicitly calls `ItemModifyJob` too.
  
  Here's the debug output without this change:
  
    org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
    org.kde.kgapi: KGAPI2::ContactCreateJob(0x556e98b54020) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full?prettyPrint=false")
    org.kde.kgapi: Status code:  201
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9")
    org.kde.kgapi: KGAPI2::ContactModifyJob(0x556e98b72920) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9")
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9?prettyPrint=false")
    org.kde.kgapi: Status code:  404
    org.kde.kgapi: Requested resource does not exist
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
    org.kde.kgapi: KGAPI2::ContactModifyJob(0x556e98b72920) Dispatching request to QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
    org.kde.kgapi: Status code:  404
    org.kde.kgapi: Requested resource does not exist
  
  The ID for newly created contact is `843a45f9-b479-46c2-bb4a-607d438e92e9`, which is not right (the right one is `41c9b4289fd31e5`).
  
  Although you seem to be correct, I've checked `AkonadiConsole` and the `remoteId` there is correct. There is indeed an `ItemModifyJob` in the job tracker.
  
  With the patch, however, the logs show following:
  
    org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
    org.kde.kgapi: KGAPI2::ContactCreateJob(0x55c3a22c3590) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full?prettyPrint=false")
    org.kde.kgapi: Status code:  201
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9")
    org.kde.kgapi: KGAPI2::ContactModifyJob(0x55c3a1df1e40) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9")
    org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9?prettyPrint=false")
    org.kde.kgapi: Status code:  200
    org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
    org.kde.kgapi: 1 requests in requestQueue.
    org.kde.kgapi: KGAPI2::ContactModifyJob(0x55c3a1df1e40) Dispatching request to QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
    org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
    org.kde.kgapi: Status code:  200
  
  i.e. everything works just fine. Any ideas?

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D28179

To: poboiko, dvratil
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200321/86c42189/attachment-0001.html>