D27906: [resources/maildir] Don't create junk files

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: dvratil, mlaurent.
Herald added a project: KDE PIM.
poboiko requested review of this revision.

REVISION SUMMARY
  As user types path inside configuration dialog, it gets checked to display
  the comment whether it's a valid maildir or not. Under the hood, it calls
  `maildir.isValid(createMissingFolders=false)`. There was a codepath, however,
  where `createMissingFolders` is not provided (and the default value is `true`),
  thus creating `cur/new/tmp` folders all over the place as user types the path.

TEST PLAN
  1. Try to create maildir inside `/tmp/dummy`
  2. Observe `cur/new/tmp` folders being created everywhere inside `/tmp/*`
  3. After applying the patch, they don't

REPOSITORY
  R44 KDE PIM Runtime

BRANCH
  dont-create-junk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27906

AFFECTED FILES
  resources/maildir/libmaildir/maildir.cpp

To: poboiko, dvratil, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200306/0e13c6a6/attachment.html>