D27768: Calendarsupport: add more info to the calendar collection tooltip

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> utils.cpp:694
>      } else {
> -        calendarType = i18nc("unknown calendar type", "unknown");
> +        calendarType = i18nc("a virtual calendar type", "Virtual");
>      }

Are you sure that all the time it's a virtiual calendar ?
(What is a virtual calendar ?)

> utils.cpp:705
> +        mimeTypeStr = mimeTypes.
> +                      replaceInStrings(QLatin1String("application/x-vnd.akonadi.calendar."),
> +                                       QLatin1String("")).

QLatin1String("") ->QString()

REPOSITORY
  R75 PIM: Calendar Support

REVISION DETAIL
  https://phabricator.kde.org/D27768

To: winterz, dvratil, mlaurent, vkrause
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200301/48ebe237/attachment.html>