D26818: Fix missing link libraries to CMakeLists.txt

[Christophe Giboudeaux]

cgiboudeaux requested changes to this revision.
cgiboudeaux added a comment.
This revision now requires changes to proceed.


  If you need to add `KF5::SyntaxHighlighting`, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.
  
  Looking at the installed headers, the only one needing a syntaxhighlighting header is sievedebugdialog.h. This header is only used by sievedebugdialog.cpp which is built by the KF5KSieveUi target.
  
  Conclusion: what needs fixing is src/ksieveui/CMakeLists.txt where `KF5::SyntaxHighlighting` shall be moved to the `PUBLIC`link targets.

REPOSITORY
  R91 PIM: Sieve Handling Library

REVISION DETAIL
  https://phabricator.kde.org/D26818

To: hgoebel, #kde_pim_junior_jobs, cgiboudeaux
Cc: cgiboudeaux, kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200122/7e78c081/attachment.html>