D26435: [Syndication] Port QRegExp to QRegularExpression
Laurent Montel
noreply at phabricator.kde.org
Mon Jan 6 12:40:46 GMT 2020
mlaurent added inline comments.
INLINE COMMENTS
> dfaure wrote in loaderutil.cpp:69
> Indeed that `(?)` looks invalid. kregexpeditor says so, at least.
>
> @mlaurent in commit dda15b0aaddec01 <https://phabricator.kde.org/R96:dda15b0aaddec01e31f862ba486a4e2876ab8eb8> you moved code around, but you also replaced `(?:HREF)` with `(?)`, while the rest of this regexp didn't change. Any reason for that?
>
> I think that either HREF should be added back, or `(?)` should be removed.
Perhaps I made an error on regexp.
Autotest still works ?
if yes it's ok.
I extracted code for testing it (testing current bug) so if all is ok...
REPOSITORY
R96 PIM: Syndication Support
REVISION DETAIL
https://phabricator.kde.org/D26435
To: ahmadsamir, dfaure, mlaurent
Cc: kde-pim, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20200106/98cd62e5/attachment.html>
More information about the kde-pim
mailing list